fixed data_url,err handling,ind component install #20723
Conversation
yarunachalam
requested review from
pdostal,
grisu48,
asmorodskyi,
ricardobranco777,
m-dati and
rbmarliere
as code owners
yarunachalam
force-pushed
the
dataurlfix
branch
3 times, most recently
from
b4d74b2 to
78b24f8
Compare
|
Along with Fix data_url, Added test_flags, increased timeout and added python package in the dependency package install |
|
Please could you add the last description in the header post, adding some detail, also removing the template Moreover, a commit message is even more important, reporting in history the modification applied: |
yarunachalam
force-pushed
the
dataurlfix
branch
12 times, most recently
from
5e31bd3 to
6f30343
Compare
yarunachalam
changed the title
yarunachalam
force-pushed
the
dataurlfix
branch
4 times, most recently
from
4815e3b to
6798e51
Compare
yarunachalam
force-pushed
the
dataurlfix
branch
from
6798e51 to
80db77e
Compare
|
Please a last more thing, consider the presence in yaml data of passwords, that should be hided. |
m-dati
dismissed
their stale review
Sorry, a password management still needed in yaml
yarunachalam
force-pushed
the
dataurlfix
branch
6 times, most recently
from
02629bd to
d5512e8
Compare
|
LGTM 🙂 |
yarunachalam
force-pushed
the
dataurlfix
branch
4 times, most recently
from
ed28552 to
57e4c1d
Compare
handled https openwebui connect error handling and pod failure and drop umberlla chart to individual component install to support ToTest
yarunachalam
force-pushed
the
dataurlfix
branch
from
57e4c1d to
03b0ddf
Compare
| assert_script_run("curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"); | ||
| my $curl_cmd = "curl --output /dev/null --silent --head --write-out \"%{http_code}\n\" -k -L https://$host_name"; | ||
| my $curl_result = script_output($curl_cmd); | ||
| record_info("http code: $curl_result \n"); | ||
| if ($curl_result == 200) { | ||
| record_info("Successfully connected to the open-webui service at $curl_cmd \n"); | ||
| } else { | ||
| die "Received unexpected HTTP error code $curl_result for $curl_cmd\n"; | ||
| } |
There was a problem hiding this comment.
Hi Yoga, please, in last commit you also added the assert_script_run("curl..., but that is the same command done below, then repeated twice, even not needed, because you already do the check of output, after script_output executed.
In a next Merge request, please, consider this kind update:
remove it:
assert_script_run("curl --output /dev/null --silent --head --write-out "%{http_code}\n" -k -L https://$host_name");
and replace the full block L244-L252 like that:
record_info("http check”, $host_name);
my $curl_cmd = "curl --output /dev/null --silent --head --write-out '%{http_code}\n' -k -L https://$host_name";
validate_script_output("$curl_cmd", qr/200/, fail_message => "Received unexpected HTTP error code from $host_name");
(replacing \" with ' in curl 🙂).
Thank you.
Fixed data_url,err handling, individual component install, included sub-routine to install from ToTest ibs url. (which will be called when openQA jobs gets triggered from ibs)
Handle https openwebui connect error handling and pod failure and drop umberlla chart to
individual component install to support ToTest
Failed job: https://openqa.suse.de/tests/16027941#step/create_aistack_env/151
Verification run: https://openqa.suse.de/tests/16209439#details