Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openqa cannot resize powerVM disk size since it is not QEMU backend #20707

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tinawang123
Copy link
Contributor

@tinawang123 tinawang123 commented Nov 29, 2024

openQA cannot resize powerVM disk image since it is not QEMU backend, skip the check here

@mloviska
Copy link
Contributor

Technically, the PR is not wrong, but it is easier to change the test variables. IMHO also should be preferable

@tinawang123
Copy link
Contributor Author

Technically, the PR is not wrong, but it is easier to change the test variables. IMHO also should be preferable

This is for powerVM job, as I know, this disk size cannot be changed, even we change the setting.
eg: https://openqa.suse.de/tests/16038586#settings HDDSIZEGB_1=32

@mloviska
Copy link
Contributor

This is for powerVM job, as I know, this disk size cannot be changed, even we change the setting. eg: https://openqa.suse.de/tests/16038586#settings HDDSIZEGB_1=32

I am unfamiliar with powerVM backend, but there should be a way how to create a larger drive in HMC. Another thing why it is better is because it would be nice to know whether the image expands on these drives as it expands in QEMU.

@tinawang123 tinawang123 force-pushed the disksize branch 2 times, most recently from 00a2098 to fd12b3d Compare December 3, 2024 07:21
@tinawang123 tinawang123 force-pushed the disksize branch 2 times, most recently from 96a547b to bf37e8d Compare December 3, 2024 08:26
@tinawang123 tinawang123 changed the title Disk size can equal to default size Openqa cannot resize powerVM disk size since it is not QEMU backend Dec 4, 2024
@rfan1
Copy link
Contributor

rfan1 commented Dec 4, 2024

This is for powerVM job, as I know, this disk size cannot be changed, even we change the setting. eg: https://openqa.suse.de/tests/16038586#settings HDDSIZEGB_1=32

I am unfamiliar with powerVM backend, but there should be a way how to create a larger drive in HMC. Another thing why it is better is because it would be nice to know whether the image expands on these drives as it expands in QEMU.

@tinawang123 I agree with @mloviska here, so I suggest skipping the check for powerVM platform at the moment, and Please add the request [32 GB disk] in https://progress.opensuse.org/issues/167893. I will try to work with @foursixnine on it.

@rfan1 rfan1 added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label Dec 4, 2024
@tinawang123
Copy link
Contributor Author

@mloviska I skipped powerVM check. @rfan1 will work to add disk size for powerVM with ticket: https://progress.opensuse.org/issues/167893. Any more suggestion? Thanks.

@mloviska
Copy link
Contributor

mloviska commented Dec 9, 2024

@mloviska I skipped powerVM check. @rfan1 will work to add disk size for powerVM with ticket: https://progress.opensuse.org/issues/167893. Any more suggestion? Thanks.

LGTM from me

@rfan1 rfan1 merged commit a01f1ca into os-autoinst:master Dec 10, 2024
10 checks passed
@tinawang123 tinawang123 deleted the disksize branch December 13, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants