Create non-root user in jeos-firstboot wizard #19964
Conversation
|
This change breaks previously passed test step, see verification run https://openqa.suse.de/tests/15187438#step/firstrun/13 Previously passed step https://openqa.suse.de/tests/15175385#step/firstrun/12 without any code change. The same test can fully pass if skip additional user creation, see https://openqa.suse.de/tests/15187495 |
|
My verification runs failed with "invalid username" error, does it need any parameters? |
Not sure how this can break this part of the code, as this is executed before the code changes. I mean, that this code precedes the modified code.
|
I haven't created needles for VMWare. As you can see the resolution of VMWare is different than the rest of the qemu tests. |
Ok, I have accidentally removed a line that was supposed not to be removed. Thanks for the hint! |
tests/jeos/firstrun.pm
Outdated
| @@ -114,6 +114,38 @@ sub verify_partition_label { | |||
| script_output('sfdisk -l') =~ m/Disklabel type:\s+$label/ or die "Wrong partion label found, expected '$label'"; | |||
| } | |||
|
|
|||
| sub create_user_in_terminal { | |||
| return if script_run("getent passwd $username") == 0; | |||
There was a problem hiding this comment.
IMO if the firstboot wizard was used to create the user, it should verify that the user was created instead of silently creating it.
There was a problem hiding this comment.
The verification itself happens later in the code, when user-console is selected. I have also added a flag and option to skip the user creation in UI by setting test suite variable.
mloviska
force-pushed
the
jfb_non_root
branch
2 times, most recently
from
7147ecb to
7ea7d9b
Compare
A new feature has been implemented and jeos-firstboot wizard can create a non root user directly in the UI. As of now the feature has landed in sle-micro 6.1 only. If `WIZARD_SKIP_USER` test variable is set, the user creation in UI will be skipped. - ticket: [test fails in firstrun - handle non-root user creation screen](https://progress.opensuse.org/issues/165180)
|
@mloviska FYI https://progress.opensuse.org/issues/165800 (I'll verify if it works without it). |
OK, reverting did not help: https://openqa.opensuse.org/tests/overview?build=test-poo165800, it's something else. |
I will take over the ticket. Thanks for the notice |
I do not see the reason why |
A new feature has been implemented and jeos-firstboot wizard can create a non root user directly in the UI. As of now the feature has landed in sle-micro 6.1 only.
ticket: test fails in firstrun - handle non-root user creation screen
Verification run: