Change regex to search for devices #19960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we explicitely searched for "infiniband" devices from Mellanox. However, if we have those configured as Ethernet devices, we won't find any devices. We know we only have ConnectX-5 devices for InfiniBand (but on the same machines we have ConnectX-4 LX which only do Ethernet - so let's explicitely search for ConnectX-5 devices instead.
schlad
approved these changes
Aug 14, 2024
czerw
reviewed
Aug 14, 2024
| @@ -42,7 +42,7 @@ sub run { | |||
| # install dependencies | |||
| zypper_call('--quiet in pciutils mstflint', timeout => 200); | |||
|
|
|||
| my @devices = split(' ', script_output("lspci | grep -i infiniband.*mellanox |cut -d ' ' -f 1")); | |||
| my @devices = split(' ', script_output("lspci | grep -i mellanox.*ConnectX-5 |cut -d ' ' -f 1")); | |||
There was a problem hiding this comment.
I would say, based on the previous experience during the review. It will be better to catch whole output to lscpi and do regex in openQA. If above fails, we dont know why as lspci output is hidden in pipes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we explicitely searched for "infiniband" devices from Mellanox.
However, if we have those configured as Ethernet devices, we won't find any devices. We know we only have ConnectX-5 devices for InfiniBand (but on the same machines we have ConnectX-4 LX which only do Ethernet - so let's explicitely search for ConnectX-5 devices instead.