EC2 Select availability zone #18485
Merged
EC2 Select availability zone #18485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdostal
requested review from
grisu48,
asmorodskyi,
ricardobranco777,
mpagot and
m-dati
as code owners
asmorodskyi
reviewed
Jan 19, 2024
lib/publiccloud/provider.pm
Outdated
| my $ipv6_address_count = get_var('PUBLIC_CLOUD_EC2_IPV6_ADDRESS_COUNT', 1); | ||
| $cmd .= "-var 'vpc_security_group_ids=$vpc_security_group_ids' " if ($vpc_security_group_ids); | ||
| $cmd .= "-var 'availability_zone=$availability_zone' " if ($availability_zone); |
There was a problem hiding this comment.
initial idea of conditional add of variable was based on optional nature of some variables , e.g. you may run job where you "-var 'enable_confidential_vm=true' " is defined but you may also run it without this . I think in this case if is not appropriate . Also I would remove it for subnet_id
Suggested change
| $cmd .= "-var 'availability_zone=$availability_zone' " if ($availability_zone); | |
| $cmd .= "-var 'availability_zone=$availability_zone' " |
There was a problem hiding this comment.
I also did the same for the VPC.
pdostal
force-pushed
the
aws_availability_zone
branch
from
18b3807 to
b1fa9a3
Compare
pdostal
force-pushed
the
aws_availability_zone
branch
from
b1fa9a3 to
83d14f8
Compare
ricardobranco777
approved these changes
Jan 19, 2024
mloviska
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically select