Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for cloud-netconfig #18095

Merged

Conversation

clanig
Copy link
Contributor

@clanig clanig commented Oct 27, 2023

This PR is to add a very basic test for cloud-netconfig to be expanded in the future.
This is a work in progress!

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@clanig clanig force-pushed the add_basic_test_for_cloud_netconfig branch 9 times, most recently from 2131886 to a2f92df Compare October 27, 2023 16:03
@clanig clanig changed the title [WIP] Add test for cloud-netconfig Add test for cloud-netconfig Oct 27, 2023
@clanig
Copy link
Contributor Author

clanig commented Oct 27, 2023

I have perltidied the file. I have no clue why the pipeline is keeps stating the opposite. I can't tidy it more.
Edit: Resolved - I was unaware that .perltidyrc of os-autoinst will be linked into the repo if make prepare is run.

tests/publiccloud/cloud_netconfig.pm Outdated Show resolved Hide resolved
tests/publiccloud/cloud_netconfig.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start @clanig! I left some suggestions here, please check if you like them.

tests/publiccloud/cloud_netconfig.pm Outdated Show resolved Hide resolved
tests/publiccloud/cloud_netconfig.pm Outdated Show resolved Hide resolved
tests/publiccloud/cloud_netconfig.pm Outdated Show resolved Hide resolved
Copy link
Member

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @clanig !

@clanig clanig force-pushed the add_basic_test_for_cloud_netconfig branch 5 times, most recently from da5bb2a to d1b6780 Compare November 24, 2023 15:06
@clanig
Copy link
Contributor Author

clanig commented Nov 24, 2023

tests/publiccloud/cloud_netconfig.pm Outdated Show resolved Hide resolved
@clanig clanig force-pushed the add_basic_test_for_cloud_netconfig branch from d1b6780 to e384c3d Compare November 24, 2023 16:10
@grisu48 grisu48 merged commit 7243317 into os-autoinst:master Nov 27, 2023
@pdostal pdostal mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants