-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for cloud-netconfig #18095
Add test for cloud-netconfig #18095
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
2131886
to
a2f92df
Compare
I have perltidied the file. I have no clue why the pipeline is keeps stating the opposite. I can't tidy it more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start @clanig! I left some suggestions here, please check if you like them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @clanig !
da5bb2a
to
d1b6780
Compare
I have updated the PR. |
d1b6780
to
e384c3d
Compare
This PR is to add a very basic test for cloud-netconfig to be expanded in the future.
This is a work in progress!
https://openqa.suse.de/tests/12701598https://openqa.suse.de/tests/12897213https://openqa.suse.de/tests/12897652