-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone os-autoinst-common into os-autoinst-distri-example #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look right to add these cache files.
subrepo: subdir: "external/os-autoinst-common" merged: "db78c61" upstream: origin: "https://github.com/os-autoinst/os-autoinst-common.git" branch: "master" commit: "db78c61" git-subrepo: version: "0.4.6" origin: "???" commit: "???" Signed-off-by: ybonatakis <ybonatakis@suse.com>
fixed. i have no idea what happened in the previous commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow it does not feel right to pull in much more content into this comparing to the minimal repo content already there from before. Maybe we should including the content using git submodules here nevertheless?
+1 |
git sub-repo which is used here is the approach taken in other repos. poo#138416 says in AC1 |
I know that and likely you know that I know that so I don't see the point of your comment |
Clone os-autoinst-common into os-autoinst-distri-example Signed-off-by: ybonatakis <ybonatakis@suse.com>
Fixes: https://progress.opensuse.org/issues/138416