Add SYNC_ASSETS_HOOK support #6131
Open
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 396 396
Lines 39611 39618 +7
=======================================
+ Hits 39211 39218 +7
Misses 400 400 ☔ View full report in Codecov by Sentry. |
Martchus
reviewed
Jan 21, 2025
This is useful when having site-local cache shared among several worker hosts. See added documentation for scenario details.
marmarek
force-pushed
the
sync-assets-hook
branch
from
f76e979 to
6960512
Compare
|
ping? |
Martchus
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when having site-local cache shared among several worker
hosts. See added documentation for scenario details.
Question: Should this setting be also exclusive to workers.ini, similar to
GENERAL_HW_CMD_DIRand few others?