Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discoverable webauthn #3567

Closed
wants to merge 8 commits into from

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Oct 9, 2023
@jonas-jonas jonas-jonas changed the base branch from jonas-jonas/reduceTestLogging to master October 9, 2023 20:09
Comment on lines +121 to +126
identifierNode := loginFlow.UI.Nodes.Find("identifier")
if identifierNode != nil {
if a, ok := identifierNode.Attributes.(*node.InputAttributes); ok {
a.Autocomplete = a.Autocomplete + " webauthn"
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This likely needs a better solution.

We want to add "webauthn" to any identifier field shown on the login page, so the browser can show the autofil UI. But with this change, the webauthn strategy no longer renders an id input field.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3567 (a2962c4) into master (df18c09) will decrease coverage by 0.06%.
Report is 12 commits behind head on master.
The diff coverage is 85.92%.

❗ Current head a2962c4 differs from pull request most recent head b5afc35. Consider uploading reports for the commit b5afc35 to get more accurate results

@@            Coverage Diff             @@
##           master    #3567      +/-   ##
==========================================
- Coverage   78.18%   78.13%   -0.06%     
==========================================
  Files         341      341              
  Lines       23052    23136      +84     
==========================================
+ Hits        18023    18077      +54     
- Misses       3679     3697      +18     
- Partials     1350     1362      +12     
Files Coverage Δ
cmd/clidoc/main.go 69.58% <100.00%> (+0.12%) ⬆️
driver/config/config.go 83.37% <100.00%> (+0.04%) ⬆️
identity/credentials_webauthn.go 100.00% <100.00%> (ø)
identity/extension_credentials.go 91.48% <100.00%> (+3.98%) ⬆️
identity/test/pool.go 99.57% <100.00%> (ø)
schema/errors.go 90.87% <100.00%> (ø)
selfservice/flow/login/flow.go 95.40% <100.00%> (ø)
selfservice/flow/verification/flow.go 88.67% <100.00%> (ø)
selfservice/hook/show_verification_ui.go 100.00% <100.00%> (ø)
selfservice/hook/web_hook.go 80.41% <100.00%> (ø)
... and 17 more

... and 2 files with indirect coverage changes

@jonas-jonas jonas-jonas closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants