-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discoverable webauthn #3567
Conversation
identifierNode := loginFlow.UI.Nodes.Find("identifier") | ||
if identifierNode != nil { | ||
if a, ok := identifierNode.Attributes.(*node.InputAttributes); ok { | ||
a.Autocomplete = a.Autocomplete + " webauthn" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This likely needs a better solution.
We want to add "webauthn"
to any identifier field shown on the login page, so the browser can show the autofil UI. But with this change, the webauthn strategy no longer renders an id
input field.
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 78.18% 78.13% -0.06%
==========================================
Files 341 341
Lines 23052 23136 +84
==========================================
+ Hits 18023 18077 +54
- Misses 3679 3697 +18
- Partials 1350 1362 +12
|
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments