-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: link oidc credentials when login #3563
Conversation
…d to login and registrations flows
…gged in identity (CORE-2006)
Signed-off-by: Henning Perl <henning.perl@ory.sh>
Codecov Report
@@ Coverage Diff @@
## master #3563 +/- ##
==========================================
- Coverage 78.17% 78.15% -0.02%
==========================================
Files 342 342
Lines 23295 23295
==========================================
- Hits 18210 18206 -4
- Misses 3709 3712 +3
- Partials 1376 1377 +1
|
1ca8889
to
c540231
Compare
ae5c9bb
to
b0f32e9
Compare
b0f32e9
to
cd14390
Compare
7775f54
to
5bff9ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I think code-wise this is good to go. Would be nice to see two or three more tests. I also really would like to have a cypress test which would make reviewing code changes (and seeing how the feature works) related to this much easier :/
Signed-off-by: Henning Perl <henning.perl@ory.sh>
Signed-off-by: Henning Perl <henning.perl@ory.sh>
Signed-off-by: Henning Perl <henning.perl@ory.sh>
Signed-off-by: Henning Perl <henning.perl@ory.sh>
Signed-off-by: Henning Perl <henning.perl@ory.sh>
test/e2e/cypress/integration/profiles/oidc/login/success.spec.ts
Outdated
Show resolved
Hide resolved
When user tries to login with OIDC for the first time but has already registered before with email/password a credentials identifier conflict may be detected by Kratos. In this case user needs to login with email/password first and then link OIDC credentials on a settings screen. This PR simplifies UX and allows user to link OIDC credentials to existing account right in the login flow, without switching to settings flow. Closes ory#2727 Closes ory#3222
Original PR: #3222
When user tries to login with OIDC for the first time but has already registered before with email/password a credentials identifier conflict may be detected by Kratos. In this case user needs to login with email/password first and then link OIDC credentials on a settings screen.
This PR simplifies UX and allows user to link OIDC credentials to existing account right in the login flow, without
switching to settings flow.
Related issue(s)
#2727
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.