Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove slow queries from update identities #3553

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 5, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested review from zepatrik and hperl as code owners October 5, 2023 08:32
@aeneasr aeneasr self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #3553 (f4dc84e) into master (8a0e496) will decrease coverage by 0.20%.
The diff coverage is 42.85%.

❗ Current head f4dc84e differs from pull request most recent head 24b551f. Consider uploading reports for the commit 24b551f to get more accurate results

@@            Coverage Diff             @@
##           master    #3553      +/-   ##
==========================================
- Coverage   78.31%   78.12%   -0.20%     
==========================================
  Files         342      341       -1     
  Lines       22869    22818      -51     
==========================================
- Hits        17910    17826      -84     
- Misses       3614     3652      +38     
+ Partials     1345     1340       -5     
Files Coverage Δ
persistence/sql/identity/persister_identity.go 81.70% <100.00%> (+0.73%) ⬆️
persistence/sql/update/update.go 75.00% <33.33%> (-5.00%) ⬇️

... and 16 files with indirect coverage changes

@aeneasr aeneasr merged commit d138abb into master Oct 6, 2023
26 checks passed
@aeneasr aeneasr deleted the fix-use-exist branch October 6, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant