Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple SSO stores first name in family_name #3551

Closed
3 of 5 tasks
leahneukirchen opened this issue Oct 4, 2023 · 0 comments · Fixed by #3556
Closed
3 of 5 tasks

Apple SSO stores first name in family_name #3551

leahneukirchen opened this issue Oct 4, 2023 · 0 comments · Fixed by #3556
Assignees
Labels
bug Something is not working.

Comments

@leahneukirchen
Copy link

Preflight checklist

Ory Network Project

No response

Describe the bug

As can be seen here, the Apple OIDC provider stores the Apple-provided "first name" in the "family_name" claim, but the "family_name" claim is for the "last name":

https://github.com/ory/kratos/blob/95dc7a20f49aa682f324b70e507ec56c20159ebb/selfservice/strategy/oidc/provider_apple.go#L142C1-L144C6

E.g. the Patreon provider does it right.

Reproducing the bug

Write a OIDC data mapper that uses family_name, it contains the first name.

Relevant log output

No response

Relevant configuration

No response

Version

HEAD

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@leahneukirchen leahneukirchen added the bug Something is not working. label Oct 4, 2023
aeneasr added a commit that referenced this issue Oct 5, 2023
@aeneasr aeneasr self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants