Skip to content

feat: rework the OTP code submit count mechanism #5125

feat: rework the OTP code submit count mechanism

feat: rework the OTP code submit count mechanism #5125

Triggered via pull request December 19, 2024 16:24
Status Cancelled
Total duration 30m 27s
Artifacts

ci.yaml

on: pull_request
Run tests and lints
9m 22s
Run tests and lints
Matrix: Run end-to-end tests
Matrix: Run Playwright end-to-end tests
Build CLI docs
0s
Build CLI docs
Generate changelog
0s
Generate changelog
Generate release
0s
Generate release
Draft newsletter
0s
Draft newsletter
Render version schema
0s
Render version schema
Release SDKs
0s
Release SDKs
Pending approval Slack notification
0s
Pending approval Slack notification
Send newsletter
0s
Send newsletter
Fit to window
Zoom out
Zoom in

Annotations

20 errors, 15 warnings, and 4 notices
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L86
1) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ 84 | await loginHydra(page) 85 | > 86 | await page.waitForURL( | ^ 87 | new RegExp(config.selfservice.default_browser_return_url), 88 | ) 89 | at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts:86:18
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L86
1) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ 84 | await loginHydra(page) 85 | > 86 | await page.waitForURL( | ^ 87 | new RegExp(config.selfservice.default_browser_return_url), 88 | ) 89 | at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts:86:18
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L1
1) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L86
1) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ 84 | await loginHydra(page) 85 | > 86 | await page.waitForURL( | ^ 87 | new RegExp(config.selfservice.default_browser_return_url), 88 | ) 89 | at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts:86:18
[chromium] › desktop/code/sms.spec.ts:87:7 › account enumeration protection off › login succeeds: test/e2e/playwright/actions/identity.ts#L17
1) [chromium] › desktop/code/sms.spec.ts:87:7 › account enumeration protection off › login succeeds Error: expect(received).toBe(expected) // Object.is equality Expected: 201 Received: 400 at ../actions/identity.ts:17 15 | data, 16 | }) > 17 | expect(resp.status()).toBe(201) | ^ 18 | return await resp.json() 19 | } 20 | at createIdentity (/home/runner/work/kratos/kratos/test/e2e/playwright/actions/identity.ts:17:25) at createIdentityWithPhoneNumber (/home/runner/work/kratos/kratos/test/e2e/playwright/actions/identity.ts:29:15) at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/code/sms.spec.ts:88:22
[chromium] › desktop/code/sms.spec.ts:100:7 › account enumeration protection off › registration succeeds: test/e2e/playwright/tests/desktop/code/sms.spec.ts#L1
2) [chromium] › desktop/code/sms.spec.ts:100:7 › account enumeration protection off › registration succeeds Test timeout of 30000ms exceeded.
[chromium] › desktop/code/sms.spec.ts:100:7 › account enumeration protection off › registration succeeds: test/e2e/playwright/models/elements/registration.ts#L43
2) [chromium] › desktop/code/sms.spec.ts:100:7 › account enumeration protection off › registration succeeds Error: locator.click: Test timeout of 30000ms exceeded. Call log: - waiting for locator('[type="submit"][name="method"][value="code"]') at ../models/elements/registration.ts:43 41 | await this.inputField("traits.phone").fill(identifier) 42 | await this.submitField("profile").click() > 43 | await this.submitField("code").click() | ^ 44 | } 45 | } 46 | at RegistrationPage.triggerRegistrationWithCode (/home/runner/work/kratos/kratos/test/e2e/playwright/models/elements/registration.ts:43:36) at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/code/sms.spec.ts:108:5
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L1
3) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Test timeout of 30000ms exceeded.
[chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login: test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts#L86
3) [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login Error: page.waitForURL: Test timeout of 30000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ 84 | await loginHydra(page) 85 | > 86 | await page.waitForURL( | ^ 87 | new RegExp(config.selfservice.default_browser_return_url), 88 | ) 89 | at /home/runner/work/kratos/kratos/test/e2e/playwright/tests/desktop/identifier_first/oidc.login.spec.ts:86:18
Run tests and lints
Process completed with exit code 2.
Run end-to-end tests (mysql)
Canceling since a higher priority waiting request for 'CI-refs/pull/4251/merge' exists
Run end-to-end tests (mysql)
The operation was canceled.
Run end-to-end tests (postgres)
Canceling since a higher priority waiting request for 'CI-refs/pull/4251/merge' exists
Run end-to-end tests (postgres)
The operation was canceled.
Run end-to-end tests (cockroach)
Canceling since a higher priority waiting request for 'CI-refs/pull/4251/merge' exists
Run end-to-end tests (cockroach)
The operation was canceled.
Run end-to-end tests (sqlite)
Canceling since a higher priority waiting request for 'CI-refs/pull/4251/merge' exists
Run end-to-end tests (sqlite)
The operation was canceled.
Generate SDKs
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/
Generate SDKs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Run Playwright end-to-end tests (sqlite)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 28.5s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 22.0s
Run Playwright end-to-end tests (postgres)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 29.7s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 22.4s
Run Playwright end-to-end tests (cockroach)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 28.3s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 21.5s
Run Playwright end-to-end tests (mysql)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: test/e2e/[mobile-chrome] › mobile/app_login.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_login.spec.ts took 27.1s
Slow Test: test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts#L1
test/e2e/[mobile-chrome] › mobile/app_recovery.spec.ts took 22.2s
Run tests and lints
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login 36 passed (2.3m)
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login 36 passed (2.4m)
🎭 Playwright Run Summary
1 flaky [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login 36 passed (2.9m)
🎭 Playwright Run Summary
3 flaky [chromium] › desktop/code/sms.spec.ts:87:7 › account enumeration protection off › login succeeds [chromium] › desktop/code/sms.spec.ts:100:7 › account enumeration protection off › registration succeeds [chromium] › desktop/identifier_first/oidc.login.spec.ts:78:9 › account enumeration protection on › login 34 passed (3.0m)