Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fosite refresh scope narrowing e2e #3403

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

james-d-elliott
Copy link
Contributor

This is a proof of conformance e2e test for the related issues.

Related issue(s)

ory/fosite#696
ory/fosite#718

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This is my first time working with cypress, and there may be a better way to handle the refreshTokenBrowserScope or I may have completely bungled it. The intent is for the flow to get an initial refresh token, narrow the scope, then broaden the scope again.

@james-d-elliott james-d-elliott changed the title Fix fosite refresh scope narrowing fix: fosite refresh scope narrowing e2e Jan 2, 2023
@james-d-elliott james-d-elliott force-pushed the fix-fosite-refresh-scope-narrowing branch from fd4ccdc to e9a1358 Compare January 2, 2023 08:25
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #3403 (e9a1358) into master (0156556) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head e9a1358 differs from pull request most recent head 322f0a8. Consider uploading reports for the commit 322f0a8 to get more accurate results

@@            Coverage Diff             @@
##           master    #3403      +/-   ##
==========================================
- Coverage   76.74%   76.70%   -0.04%     
==========================================
  Files         123      123              
  Lines        9022     9076      +54     
==========================================
+ Hits         6924     6962      +38     
- Misses       1657     1672      +15     
- Partials      441      442       +1     
Impacted Files Coverage Δ
driver/registry_sql.go 66.99% <0.00%> (-7.21%) ⬇️
flow/flow.go 92.17% <0.00%> (-1.01%) ⬇️
persistence/sql/persister_oauth2.go 81.36% <0.00%> (-0.77%) ⬇️
client/manager_test_helpers.go 98.51% <0.00%> (-0.02%) ⬇️
driver/factory.go 59.18% <0.00%> (ø)
oauth2/handler.go 66.50% <0.00%> (ø)
driver/registry_base.go 85.93% <0.00%> (ø)
driver/config/provider.go 82.55% <0.00%> (ø)
consent/strategy_default.go 69.59% <0.00%> (ø)
jwk/manager_test_helpers.go 78.60% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant