-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a flag and a routine for flushing inactive login sessions #3133
base: master
Are you sure you want to change the base?
feat: add a flag and a routine for flushing inactive login sessions #3133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3133 +/- ##
==========================================
+ Coverage 76.82% 79.61% +2.78%
==========================================
Files 123 112 -11
Lines 8976 8001 -975
==========================================
- Hits 6896 6370 -526
+ Misses 1652 1225 -427
+ Partials 428 406 -22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I created PR which contains regenerated docs |
2286d79
to
ca7970e
Compare
6d331bb
to
1acf097
Compare
@aeneasr It seems like this has stalled for a long time. |
That's true |
I think after the merging of authentication request tables, the correct SQL is now: delete from hydra_oauth2_authentication_session
where not exists (
select from hydra_oauth2_flow where login_session_id = hydra_oauth2_authentication_session.id
); works at least in postgresql. |
Dear @norand94 are you still working on this? |
Why has this stalled? For me it seems that this query does the trick:
|
Related issue(s)
#2561
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments