-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use int64 type for claims with timestamps #600
Conversation
@aeneasr and @mitar: This PR transform claims with timestamps to |
72a7744
to
223ced5
Compare
223ced5
to
b6a09a0
Compare
I like it! |
Could you please take a look at the failing test cases? Thanks! :) |
b31afb3
to
346c3d7
Compare
fixed |
346c3d7
to
725b149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job as always @narg95 - thank you!
@aeneasr my pleasure :) |
Proposed changes
Uses
int64
for timestamped claim values.Checklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).