Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update reflections mod past problem version #587

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

bnaylor
Copy link
Contributor

@bnaylor bnaylor commented Apr 23, 2021

Related issue

I didn't open an issue, it's a minor version bump for a dependency.

Proposed changes

This change bumps the minor version of the imported module oleiade/reflections from v1.0.0 to v1.0.1.

There was an issue involving a change to the tags on the project that can result in transitive dependencies failing go checksums:

Result:

verifying github.com/oleiade/reflections@v1.0.0/go.mod: checksum mismatch
	downloaded: h1:rdFxbxq4QXVZWj0F+e9jqjDkc7dbp97vkRixKo2JR60=
	go.sum:     h1:RbATFBbKYkVdqmSFtx13Bb/tVhR0lgOBXunWTZKeL4w=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • [n/a] I have added necessary documentation within the code base (if
    appropriate).

Further comments

go test ./...
ok  	github.com/ory/fosite	(cached)
?   	github.com/ory/fosite/compose	[no test files]
ok  	github.com/ory/fosite/handler/oauth2	(cached)
ok  	github.com/ory/fosite/handler/openid	(cached)
ok  	github.com/ory/fosite/handler/pkce	(cached)
ok  	github.com/ory/fosite/handler/rfc7523	(cached)
ok  	github.com/ory/fosite/integration	(cached)
?   	github.com/ory/fosite/integration/clients	[no test files]
?   	github.com/ory/fosite/internal	[no test files]
ok  	github.com/ory/fosite/storage	(cached)
ok  	github.com/ory/fosite/token/hmac	(cached)
ok  	github.com/ory/fosite/token/jwt	(cached)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants