Support latest markdown releases #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Markdown releases do no more require [md_globals](https://python-markdown.github.io/change_log/release-3.0/#md_globals-keyword-deprecated-from-extension-api) in `extendMarkdown`.
|
I came across the same issue and came to the same conclusion, so +1 with this change being correct. |
|
@oruelle - Any thoughts of merging this change and releasing an updated PyPi package? |
Strangemother
approved these changes
Sep 18, 2022
|
@oruelle It looks like this change is straightforward to implement. Can you give it a look? |
graehu
reviewed
Nov 15, 2023
| @@ -85,7 +85,7 @@ def run(self, lines): | |||
| class MermaidExtension(Extension): | |||
| """ Add source code hilighting to markdown codeblocks. """ | |||
|
|
|||
| def extendMarkdown(self, md, md_globals): | |||
There was a problem hiding this comment.
md_globals=None for backwards compat, then there's no reason not to take this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code to support the latest Python-Markdown releases, which do no more require md_globals in
extendMarkdown.