-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mermaid extension erase all unicode in html output #2
Comments
Same here, even with accented characters. It even removes all non basic ascii characters from the whole markdow file (not only from mermaid code). |
@oruelle why is it useful to remove all characters except acsii with strip_notprintable() ? This breaks unicode pages. Can you give us some cases where is useful ? Maybe strip_notprintable should be call in some if else conditions to be defined. Thanks |
i have a lot problems with the current version too and have as fix only add strip_notprintable(line) in the re.mach funktions added and the raw lines not modificid, this help a lot to found the correct end and start from a code block i remoed all other strip_notprintable() m_start = MermaidRegex.match( strip_notprintable(line) ) hope this help |
Apply oruelle#2 (comment) to unfilter non-ascii characters such as Japanese or Emoji.
I'm running into a variant of this with the latest mindmap
root
topic
subtopic
into
which won't render. As others before me have said, I'm not what problem we're trying to solve by stripping when we are inside of mermaid code -- why can't the mermaid code be sent as-is to the mermaid parser? |
This commit should be cancelled since it gives bad results |
fix long-known bug during dealing with unicode which has puzzled and effected some projects. You may find the detail in oruelle#2. Why I leave two `new_lines.append(line)`? Because in oruelle#2, @rayalan says his app depends on leading space, as a result I can't judge what we should do exactly. However, lets fix this to let most of the projects runs without problem again.
The text was updated successfully, but these errors were encountered: