Add Enum.Match #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m matching logic ✅ (enum_test.go): Add tests for new Match method in Enum, testing with Book and Color enums
orsinium
requested changes
Apr 12, 2024
… Equal for better clarity ✨ (enum.go): Add Parse function to replace Match method for better separation of concerns 🐛 (enum_test.go): Update tests to reflect changes in enum.go, replacing Match with Parse and updating test names
|
@orsinium PTAL |
orsinium
approved these changes
Apr 12, 2024
|
Beautiful! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Matcher interface and Match method to Enum for custom matching logic.
This is especially beneficial when the value type is struct, which means that be able to implement a custom matcher.