Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run travis on application #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

run travis on application #19

wants to merge 3 commits into from

Conversation

reiser
Copy link

@reiser reiser commented Sep 4, 2019

Can you please merge travis into this repo as well? I am always unsure to upgrade.

git clone --single-branch --branch 3.1.12 git@github.com:oroinc/platform-application.git oro-platform-application
git checkout 3.1.12
composer install
bin/phpunit --testsuite=unit --colors=always --verbose

FAILURES!
Tests: 27951, Assertions: 68588, Failures: 97, Skipped: 11, Incomplete: 1.

@anyt
Copy link
Contributor

anyt commented Sep 4, 2019

Oro team develop all the Oro applications and packages in a monolithic repository, that is private because we have all the public and enterprise applications all in once there.
Every release this repository splits to the public repositories like this one.

For the monolithic, we use Jenkins CI to test all the pull requests and releases, and we never publish the version with failed tests. Also, we do manual testing of all the released features and bugfixes every patch release and run a significant manual regression testing every minor release.

Now we have the issue, that some tests are designed to run only from the monolithic repository. Even when we test separate packages and applications in it, these tests can fail in public repositories because of dependency on the environment optimizations done on Jenkins, like parallel suites. As a result, the tests can fail when you run them from the public repository, but this doesn't mean that the tested feature is broken.

I will check with the team, how we can manage this issue. By making the test results available publicly or improve the isolation of the test so you will be able to run them from the repository.

As for the Travis, a few years ago, we ran tests in a public Travis builds, but we met the resources limit and moved to the private Jenkins. So I don't think we'll return to the Travis anytime soon.

@reiser
Copy link
Author

reiser commented Sep 6, 2019

Got it and totally agree circleci and travis are too limited. Reason you released https://github.com/oroinc/environment which should exactly do the job?

I was running from here as well and same it broke.
git clone git@github.com:oroinc/environment.git .env
.env/ci/run.sh unit ../oro-platform-application

Can you confirm as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants