Support for 4D arrays in ZFP compressor #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing preprocessor ZFP version check
vicentebolea
requested changes
Sep 16, 2024
vicentebolea
approved these changes
Sep 19, 2024
|
feel free to merge |
|
Test |
|
Probably not a real failure. I've forced a rerun of that job. |
|
WriteStateOnly is a new test, it maybe flaky. It should not hold this PR from being merged. |
I agree it should not hold this PR from being merged. But the test should not be flaky, what was the error? I didn't see it. |
|
The reader reported steps=0, then a series of failures after that. Perhaps the writer died prematurely. But a rerun fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a small yet potentially valuable enhancement for users who work with 4D data arrays and require support for ZFP data compression.
While working on data compression for Neko, we encountered the need to compress 4D data arrays using the ZFP compressor, specifically the
zfp_field_4d()function. This feature is available starting with ZFP version 0.5.4 https://zfp.readthedocs.io/en/release0.5.4/versions.htmlThe current ADIOS2 release supports ZFP version 0.5.3. Therefore, a CMake source check has been introduced to conditionally enable this feature if the system's ZFP version is 0.5.4 or higher.
The branch has been successfully tested with our Neko use case.