-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 4D arrays in ZFP compressor #4344
Conversation
replacing preprocessor ZFP version check
feel free to merge |
Test |
Probably not a real failure. I've forced a rerun of that job. |
WriteStateOnly is a new test, it maybe flaky. It should not hold this PR from being merged. |
I agree it should not hold this PR from being merged. But the test should not be flaky, what was the error? I didn't see it. |
The reader reported steps=0, then a series of failures after that. Perhaps the writer died prematurely. But a rerun fixed it. |
This PR introduces a small yet potentially valuable enhancement for users who work with 4D data arrays and require support for ZFP data compression.
While working on data compression for Neko, we encountered the need to compress 4D data arrays using the ZFP compressor, specifically the
zfp_field_4d()
function. This feature is available starting with ZFP version 0.5.4 https://zfp.readthedocs.io/en/release0.5.4/versions.htmlThe current ADIOS2 release supports ZFP version 0.5.3. Therefore, a CMake source check has been introduced to conditionally enable this feature if the system's ZFP version is 0.5.4 or higher.
The branch has been successfully tested with our Neko use case.