Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add the same treatment to attributes as to variables before: … #4076

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

pnorbert
Copy link
Contributor

@pnorbert pnorbert commented Mar 6, 2024

…return scalars (0-dim ndarray) for single value attributes.

@pnorbert pnorbert added this to the v2.10.0 milestone Mar 6, 2024
…return scalars (0-dim ndarray) for single value attributes.
…always in streaming), read returns a 0-dim numpy array (single value). If the variable has multiple steps (only in ReadRandomAccess mode), read returns a 1-dim numpy array even if the step selection is a single step. This way, read of a certain variable always results in the same type of array no matter the number of steps selected.

- Python: fix for string attributes: return a string, not a list of one element which is a string, to be consistent with string global values and with other APIs.
eisenhauer
eisenhauer previously approved these changes Mar 8, 2024
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@pnorbert pnorbert merged commit c317c35 into ornladios:master Mar 8, 2024
39 checks passed
@pnorbert pnorbert deleted the python-scalar-attributes branch March 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants