-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to v2.10.0-rc1 #3975
Bump version to v2.10.0-rc1 #3975
Conversation
1beae8c
to
b60f037
Compare
@eisenhauer we are seeing interesting errors here, for once somewhere in the bpserializer it consider each component of the version string to be a single character, thus 2.10.0 is converted to 2.1.0 leading to the erros that we see. Here is a thought, how about we discard the patch release bit here? We already promise ABI compatible patch releases. |
However by doing this we might just break compatibility with BP files prior 2.10. Maybe a best course of action is to set this as 2.9 for this RC release and let you guys figure out how to resolve this for the next RC. |
Try this patch. It lets the BP3/4 minor version go beyond 0x39 ascii, which lets the read side still read it properly because the reader takes the character read and subtracts 0x30 from it:
There is still a problem with BP3 and BP4 because they assume a fixed size for the release string, and while this ascii patch will help with the minor version (as long as we don't move too close to three digits), the patch version handling is harder because the patch number might get much bigger than the minor version. But this might do for now... |
fbdf157
to
648843d
Compare
BP files bits assigned to the minor version of ADIOS2 is a single character long, when moving to adios 2.10.0 we run into an ASCII overflow here. This patch uses the next ASCII character after '9' for minor versions after 9. This will buy us sometime to resolve this issue.
648843d
to
22976bf
Compare
@eisenhauer your patch seems to have resolved this issue. |
No description provided.