Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to query local arrays #3824

Closed
wants to merge 45 commits into from
Closed

Conversation

guj
Copy link
Contributor

@guj guj commented Sep 23, 2023

  1. removed unused code sections
  2. added support for Local Arrays
  3. added test for local arrays in python
  4. result can be returned as vector of start/count (global array only), or vector of block ids

2) added support for Local Arrays
3) added test for local arrays in python
4) result can be returned as vector of start/count (global array only),  or vector of block ids
@guj guj requested review from pnorbert and anagainaru and removed request for vicentebolea September 25, 2023 16:29
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good at a first glance, I will try running it later today and see how it works with my code. My concern is with the testing code, we can discuss tomorrow at the meeting.

examples/query/test.cpp Outdated Show resolved Hide resolved
Comment on lines -34 to 38
file << " <range compare=\"GT\" value=\"6.6\"/>" << std::endl;
file << " <range compare=\"GT\" value=\"100.6\"/>" << std::endl;
file << " <range compare=\"LT\" value=\"-0.17\"/>" << std::endl;
file << " <op value=\"AND\">" << std::endl;
file << " <range compare=\"LT\" value=\"2.9\"/>" << std::endl;
file << " <range compare=\"LT\" value=\"11.9\"/>" << std::endl;
file << " <range compare=\"GT\" value=\"2.8\"/>" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use the heat transfer data for the Testing files. In the examples you could use whatever you want, but when testing a function I would use some data that is easy to check correctness for. It is not clear to me why the correct answer for BP4 is {2,1,1}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guj , can you address @anagainaru 's concerns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I didn't see them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not use heat transfer data. Rather it first writes a file, and then query it.

eisenhauer and others added 19 commits September 26, 2023 16:22
Add Memory Selection to SST, and prototype a mechanism for running st…
…ios#3834)

* Tweak Remote class and test multi-threaded file remote access

* rework

* Bad clang-format

* New formulation
1) Make all examples individually compilable
2) Make examples' executable names be consistent
3) Move certain examples in the right folders
4) Rename certain examples for clarity
5) Make all examples installable
6) Fix Python formatting using black
7) Add licence documentation wherever it's missing
1) Make all examples individually compilable
2) Make examples' executable names be consistent
3) Rename certain examples for clarity
4) Make all examples installable
5) Fix Python formatting using black
6) Add licence documentation wherever it's missing
* Fix usage of DESTDIR for absolute paths

* Update cmake/install/post/generate-adios2-config.sh.in

---------

Co-authored-by: Tilman Dannert <dannert@rzg.mpg.de>
eisenhauer
eisenhauer previously approved these changes Oct 23, 2023
@@ -99,7 +99,7 @@ void BPQueryTest::QueryIntVar(const std::string &fname, adios2::ADIOS &adios,

std::vector<size_t> rr;
if (engineName.compare("BP4") == 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll bite. It looks like the correct output depends upon the engine that you use. Why?

2) added support for Local Arrays
3) added test for local arrays in python
4) result can be returned as vector of start/count (global array only),  or vector of block ids
…queryLocalArray

* 'queryLocalArray' of https://github.com/guj/ADIOS2:
  Update test.cpp
  modified test. it failed  because I consolidate block when all subblocks are touched
  removed extra ;
  older clang-format
  clang-format v16
  1) removed unused code sections 2) added support for Local Arrays 3) added test for local arrays in python 4) result can be returned as vector of start/count (global array only),  or vector of block ids
@guj
Copy link
Contributor Author

guj commented Oct 23, 2023

Too many commits after rebase.
Start a new pull request instead: #3868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants