-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Create static minimal build #3760
Merged
vicentebolea
merged 5 commits into
ornladios:master
from
vicentebolea:create-minimal-static-build
Aug 23, 2023
Merged
ci: Create static minimal build #3760
vicentebolea
merged 5 commits into
ornladios:master
from
vicentebolea:create-minimal-static-build
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicentebolea
force-pushed
the
create-minimal-static-build
branch
12 times, most recently
from
August 16, 2023 01:23
58ca66d
to
c65e3bd
Compare
We are hitting an error here https://open.cdash.org/test/1176036167: The test expect to always use BP5. Does it make sense to have a build BP5=OFF? |
vicentebolea
force-pushed
the
create-minimal-static-build
branch
4 times, most recently
from
August 16, 2023 16:34
bf2f330
to
98625aa
Compare
vicentebolea
force-pushed
the
create-minimal-static-build
branch
3 times, most recently
from
August 22, 2023 21:24
1a95b26
to
fdf4197
Compare
vicentebolea
force-pushed
the
create-minimal-static-build
branch
3 times, most recently
from
August 23, 2023 01:35
eb1d4ae
to
df82671
Compare
vicentebolea
force-pushed
the
create-minimal-static-build
branch
from
August 23, 2023 15:43
df82671
to
3f4c83f
Compare
vicentebolea
force-pushed
the
create-minimal-static-build
branch
from
August 23, 2023 16:09
3f4c83f
to
1291865
Compare
@eisenhauer can you review this? Thanks :) |
eisenhauer
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can see.
This was referenced Aug 23, 2023
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed since the current static builds fails to build the unit tests since they take more disk space than what GH give us.
It is also worth to have a
minimal
build to test that setup, this is valuable for users that want to embedded adios somewhere.Fixes: #3751
Fixes: #3148