-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add two static builds #3749
CI: add two static builds #3749
Conversation
b28d77f
to
a8f9b52
Compare
8d4dc2c
to
a5a8576
Compare
a5a8576
to
dcb2b3c
Compare
dcb2b3c
to
8a333d8
Compare
This PR enables two static builds for ADIOS2 however they do not build the adios2 unittests, the reason is that each of our unit test is built in a single file, meaning that when enabling all the common options we build over 200 binaries. When we do a static build this is a problem since each of this binary will have the same size as the sum of all its dependencies. This result in Github actions returning a out-of-space error. In order to enable tests in the static build we must group the tests in a single (or a few) binaries with the cmake function |
@scottwittenburg can you review this? I am not sure if this is the best approach. I am adding two builds for linux GHA which results in a total of 13 builds as compared to the maximum of 16 simultaneous CI jobs. |
What other option is there? Other than removing two of the existing builds to keep the number fixed? This seems ok to me, so I'm just approving. But let me know if I missed the point. |
Closes #1828