Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add two static builds #3749

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Aug 10, 2023

Closes #1828

@vicentebolea vicentebolea force-pushed the enable-static-builds branch 4 times, most recently from b28d77f to a8f9b52 Compare August 10, 2023 23:24
@vicentebolea
Copy link
Collaborator Author

This PR enables two static builds for ADIOS2 however they do not build the adios2 unittests, the reason is that each of our unit test is built in a single file, meaning that when enabling all the common options we build over 200 binaries. When we do a static build this is a problem since each of this binary will have the same size as the sum of all its dependencies. This result in Github actions returning a out-of-space error.

In order to enable tests in the static build we must group the tests in a single (or a few) binaries with the cmake function create_test_sourcelist https://cmake.org/cmake/help/book/mastering-cmake/chapter/Testing%20With%20CMake%20and%20CTest.html

@vicentebolea
Copy link
Collaborator Author

@scottwittenburg can you review this? I am not sure if this is the best approach. I am adding two builds for linux GHA which results in a total of 13 builds as compared to the maximum of 16 simultaneous CI jobs.

@scottwittenburg
Copy link
Collaborator

I am not sure if this is the best approach. I am adding two builds for linux GHA which results in a total of 13 builds as compared to the maximum of 16 simultaneous CI jobs.

What other option is there? Other than removing two of the existing builds to keep the number fixed? This seems ok to me, so I'm just approving. But let me know if I missed the point.

@vicentebolea vicentebolea merged commit 556a695 into ornladios:master Aug 11, 2023
27 checks passed
@vicentebolea vicentebolea deleted the enable-static-builds branch August 11, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants