Tweaks for BP5 on windows. #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code extracted from:
https://github.com/GTkorvo/enet.git
at commit f93beb4e7d8179e2b38a88a40b595649f2405913 (master).
Upstream Shortlog
-----------------
# By enet Upstream * upstream-enet: enet 2023-06-08 (f93beb4e)
Code extracted from:
https://github.com/GTkorvo/EVPath.git
at commit e9be8e635f0e2b578f88957b999601b1fc74dde0 (master).
Upstream Shortlog
-----------------
# By EVPath Upstream * upstream-EVPath: EVPath 2023-06-10 (e9be8e63)
Code extracted from:
https://github.com/GTkorvo/atl.git
at commit f3c23577274edec8685bd7cbbeb7eb35aa9f48e9 (master).
Upstream Shortlog
-----------------
# By atl Upstream * upstream-atl: atl 2023-06-07 (f3c23577)
Code extracted from:
https://github.com/GTkorvo/ffs.git
at commit 46d79432dc67ee91a56ec2acbdc09624b3e4bd08 (master).
Upstream Shortlog
-----------------
# By ffs Upstream * upstream-ffs: ffs 2023-06-06 (46d79432)
Code extracted from:
https://github.com/GTkorvo/dill.git
at commit 6c94efb329e239d654b69d6640c47c0b9bb778c5 (master).
Upstream Shortlog
-----------------
# By dill Upstream * upstream-dill: dill 2023-06-09 (6c94efb3)
pnorbert
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just enables BP5 on windows visual studio, not SST. Many of these tweaks are simply to make VS happy about types (it's pickier on warning about conversions), but there were some bug fixes also.
Additionally, extensive updates were made to thirdparty libraries, including enet, dill, ffs, atl, and EVpath. The versions of those packages have changed (because the whole visual studio 'long' is 32 bits on a 64bit machine issue required interface changes), so CMake has been modified in order to be happy. At some point, we'll think about making sure that SST works, but first this.