Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for BP5 on windows. #3682

Merged
merged 12 commits into from
Jul 3, 2023
Merged

Tweaks for BP5 on windows. #3682

merged 12 commits into from
Jul 3, 2023

Conversation

eisenhauer
Copy link
Member

@eisenhauer eisenhauer commented Jul 2, 2023

This just enables BP5 on windows visual studio, not SST. Many of these tweaks are simply to make VS happy about types (it's pickier on warning about conversions), but there were some bug fixes also.

  • Short circuiting BP5 MinMax so that calling it with String doesn't seg fault.
  • Flushing all files in EndStep() in BP5Writer (this is required to accommodate tests which rely upon this behaviour).
  • Tweaking the ZeroDims declaration in BP5Writer to avoid premature deallocation of the base info.
  • replacing calls to index() and rindex() with strchr and strrchr.
  • various size_t vs long fixes
  • Extending timeouts on tests that take longer on the VS platforms

Additionally, extensive updates were made to thirdparty libraries, including enet, dill, ffs, atl, and EVpath. The versions of those packages have changed (because the whole visual studio 'long' is 32 bits on a 64bit machine issue required interface changes), so CMake has been modified in order to be happy. At some point, we'll think about making sure that SST works, but first this.

enet Upstream and others added 11 commits July 2, 2023 15:29
Code extracted from:

    https://github.com/GTkorvo/enet.git

at commit f93beb4e7d8179e2b38a88a40b595649f2405913 (master).

Upstream Shortlog
-----------------
# By enet Upstream
* upstream-enet:
  enet 2023-06-08 (f93beb4e)
Code extracted from:

    https://github.com/GTkorvo/EVPath.git

at commit e9be8e635f0e2b578f88957b999601b1fc74dde0 (master).

Upstream Shortlog
-----------------
# By EVPath Upstream
* upstream-EVPath:
  EVPath 2023-06-10 (e9be8e63)
Code extracted from:

    https://github.com/GTkorvo/atl.git

at commit f3c23577274edec8685bd7cbbeb7eb35aa9f48e9 (master).

Upstream Shortlog
-----------------
# By atl Upstream
* upstream-atl:
  atl 2023-06-07 (f3c23577)
Code extracted from:

    https://github.com/GTkorvo/ffs.git

at commit 46d79432dc67ee91a56ec2acbdc09624b3e4bd08 (master).

Upstream Shortlog
-----------------
# By ffs Upstream
* upstream-ffs:
  ffs 2023-06-06 (46d79432)
Code extracted from:

    https://github.com/GTkorvo/dill.git

at commit 6c94efb329e239d654b69d6640c47c0b9bb778c5 (master).

Upstream Shortlog
-----------------
# By dill Upstream
* upstream-dill:
  dill 2023-06-09 (6c94efb3)
@eisenhauer eisenhauer merged commit 9785b9a into ornladios:master Jul 3, 2023
@eisenhauer eisenhauer deleted the BP5 branch July 3, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants