Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADIOS2 HDF5 VOL with basic set of capability flags #3632

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

jhendersonHDF
Copy link
Contributor

This PR updates the ADIOS2 HDF5 VOL connector to return a basic set of capability flags so that it can be tested with the HDF5 VOL tests repository. Otherwise, the tests would fail when trying to call the H5Pget_vol_cap_flags API routine to retrieve the connector's capability flags.

Defining the new H5VL_adios2_introspect_get_cap_flags callback function allows HDF5 to properly resolve situations where the connector may have other connectors stacked on top of it that pass operations down and need to check if the connectors below it support certain functionality.

@vicentebolea vicentebolea requested a review from guj May 24, 2023 23:37
guj
guj previously approved these changes May 25, 2023
Copy link
Contributor

@guj guj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the flags.

@vicentebolea
Copy link
Collaborator

@jhendersonHDF I rebased/solved conflict so that it can be merged

Copy link
Contributor

@guj guj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jhendersonHDF
Copy link
Contributor Author

Thanks for rebasing this @vicentebolea!

@vicentebolea
Copy link
Collaborator

This is approved, should it be merged?

@guj guj merged commit c8b7b66 into ornladios:master Aug 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants