Update ADIOS2 HDF5 VOL with basic set of capability flags #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guj
previously approved these changes
May 25, 2023
vicentebolea
force-pushed
the
feature/h5vol_cap_flags
branch
from
7d6ece8
to
c8ea27d
Compare
|
@jhendersonHDF I rebased/solved conflict so that it can be merged |
vicentebolea
force-pushed
the
feature/h5vol_cap_flags
branch
from
c8ea27d
to
90bafd4
Compare
|
Thanks for rebasing this @vicentebolea! |
|
This is approved, should it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ADIOS2 HDF5 VOL connector to return a basic set of capability flags so that it can be tested with the HDF5 VOL tests repository. Otherwise, the tests would fail when trying to call the H5Pget_vol_cap_flags API routine to retrieve the connector's capability flags.
Defining the new H5VL_adios2_introspect_get_cap_flags callback function allows HDF5 to properly resolve situations where the connector may have other connectors stacked on top of it that pass operations down and need to check if the connectors below it support certain functionality.