ci,ascent: enable ascent builds #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicentebolea
commented
May 10, 2023
vicentebolea
force-pushed
the
enable-olcf-build
branch
from
36ed788
to
10377ee
Compare
vicentebolea
force-pushed
the
enable-olcf-build
branch
9 times, most recently
from
f8f954d
to
cad3bc6
Compare
vicentebolea
force-pushed
the
enable-olcf-build
branch
from
cad3bc6
to
c392286
Compare
scottwittenburg
previously approved these changes
May 11, 2023
There was a problem hiding this comment.
I'm just reviewing the changes related to CI here, and leaving the changes in source/ to someone else. I had one question about printing out the all environment variables, but otherwise I didn't notice any gotchas. It's great you got this working @vicentebolea!
vicentebolea
force-pushed
the
enable-olcf-build
branch
from
c392286
to
cf7a879
Compare
scottwittenburg
approved these changes
May 11, 2023
|
@eisenhauer can you review the source code changes? |
eisenhauer
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3601
fixes: #3598
fixes: #3551
fixes: #3599
fixes: #3546
fixes: #3523
fixes: #3603
related: #3602
This PR adds the following power9 builds:
The builds are accessible from the Github PR page and it is shown as one more check.
Builds are here: https://code.ornl.gov/ecpcitest/adios2/-/pipelines