-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci,ascent: enable ascent builds #3610
ci,ascent: enable ascent builds #3610
Conversation
36ed788
to
10377ee
Compare
f8f954d
to
cad3bc6
Compare
cad3bc6
to
c392286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just reviewing the changes related to CI here, and leaving the changes in source/
to someone else. I had one question about printing out the all environment variables, but otherwise I didn't notice any gotchas. It's great you got this working @vicentebolea!
c392286
to
cf7a879
Compare
@eisenhauer can you review the source code changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the C++ changes are OK...
fixes: #3601
fixes: #3598
fixes: #3551
fixes: #3599
fixes: #3546
fixes: #3523
fixes: #3603
related: #3602
This PR adds the following power9 builds:
The builds are accessible from the Github PR page and it is shown as one more check.
Builds are here: https://code.ornl.gov/ecpcitest/adios2/-/pipelines