Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation that append mode works with BP4 engine. #2370

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Fix documentation that append mode works with BP4 engine. #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e2433a
Append mode has been completed.
NAThompson Jul 9, 2020
e165808
Apply clang-format.
NAThompson Jul 9, 2020
6751221
Document that adios2::Mode::Append is only available for bp4.
NAThompson Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bindings/CXX11/adios2/cxx11/IO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ class IO
* Open an Engine to start heavy-weight input/output operations.
* @param name unique engine identifier
* @param mode adios2::Mode::Write, adios2::Mode::Read, or
* adios2::Mode::Append (not yet support)
* adios2::Mode::Append (BP4 only)
* @return engine object
*/
Engine Open(const std::string &name, const Mode mode);
Expand All @@ -265,7 +265,7 @@ class IO
* MPI Collective function as it calls MPI_Comm_dup
* @param name unique engine identifier within IO
* @param mode adios2::Mode::Write, adios2::Mode::Read, or
* adios2::Mode::Append (not yet support)
* adios2::Mode::Append (BP4 only)
* @param comm new communicator other than ADIOS object's communicator
* @return engine object
*/
Expand Down
5 changes: 3 additions & 2 deletions source/adios2/engine/bp3/BP3Writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,9 @@ void BP3Writer::InitBPBuffer()
{
if (m_OpenMode == Mode::Append)
{
throw std::invalid_argument(
"ADIOS2: OpenMode Append hasn't been implemented, yet");
throw std::invalid_argument("ADIOS2: Mode::Append is only available in "
"BP4; it is not implemented "
"for BP3 files.");
// TODO: Get last pg timestep and update timestep counter in
}
else
Expand Down