Go back using active flag in metadata index header instead of using a… #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be targeting the release branch? |
|
@chuckatkins This docs test is new, isn't it? What can I do here to pass? |
pnorbert
force-pushed
the
active-flag-back
branch
from
7d28d4a
to
f29b2e9
Compare
|
Okay, I rebased current master to get the latest docs environment. @chuckatkins This fix should go to release. Should I make another PR to the release branch? |
… separate 'active' file, which introduced race conditions. A separate file cannot guarantee the order of the following events: removal of active file (file system's metadata server operation), and arrival of content of metadata index file on disk (a storage operation). Index content may be en route to disk but held up to indefinite time while the active file disappears, so a reader may not get the last steps believing the file is not active anymore. In contrast, active flag is written to the same file after the last steps are written, so order is guaranteed as long as the file system guarantees the order of writes to the same file.
Yes the docs test is new, It's a hidden feature in ReadTheDocs that I had their admins enable for our project. They are now passing on master and release.
No need. You can "edit" the pr to change the target branch, which I just did. |
pnorbert
force-pushed
the
active-flag-back
branch
from
f29b2e9
to
006e326
Compare
chuckatkins
pushed a commit
that referenced
this pull request
May 19, 2020
Go back using active flag in metadata index header instead of using a…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… separate 'active' file, which introduced race conditions. A separate file cannot guarantee the order of the following events: removal of active file (file system's metadata server operation), and arrival of content of metadata index file on disk (a storage operation). Index content may be en route to disk but held up to indefinite time while the active file disappears, so a reader may not get the last steps believing the file is not active anymore. In contrast, active flag is written to the same file after the last steps are written, so order is guaranteed as long as the file system guarantees the order of writes to the same file.