Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korteweg de-Vries equation example #2080

Closed
wants to merge 7 commits into from
Closed

Korteweg de-Vries equation example #2080

wants to merge 7 commits into from

Conversation

NAThompson
Copy link
Contributor

@NAThompson NAThompson commented Mar 30, 2020

This should help with #2000.

A couple things:

  • I should probably add a "step attribute" for the time.
  • I will add graphing ability once the Python binding problems are hammered out.

@NAThompson NAThompson changed the title Commit very basic example for Korteweg de-Vries equation. Korteweg de-Vries equation example Mar 30, 2020
@pnorbert
Copy link
Contributor

Shouldn't we have this rather in https://github.com/ornladios/ADIOS2-Examples?

@NAThompson
Copy link
Contributor Author

NAThompson commented Mar 30, 2020

@pnorbert : That's fine; either way. But the fact that I had no clue that the ADIOS2-examples repo existed, along with the existence of an examples directory here, does not indicate that many other people will find it. It also appears less well-maintained, so I fear it will be susceptible to bitrot.

Finally, the Python code will act as a unit test for issue #2081.

@williamfgc
Copy link
Contributor

williamfgc commented Apr 2, 2020

@NAThompson I can help you migrating to the ADIOS2-Examples repo (in my spare time). Reality is, ADIOS2-Examples is easy to maintain as long as ADIOS2 doesn't break its API. As for unit tests, they should be under testing, there is nothing run/verified under examples so it got pretty outdated over time. Bonus: ADIOS2-Examples has CI on Azure.

@NAThompson
Copy link
Contributor Author

@williamfgc : Ok, cool. I'll open a PR in the examples project.

@NAThompson NAThompson closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants