-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korteweg de-Vries equation example #2080
Conversation
Shouldn't we have this rather in https://github.com/ornladios/ADIOS2-Examples? |
@pnorbert : That's fine; either way. But the fact that I had no clue that the ADIOS2-examples repo existed, along with the existence of an Finally, the Python code will act as a unit test for issue #2081. |
@NAThompson I can help you migrating to the ADIOS2-Examples repo (in my spare time). Reality is, ADIOS2-Examples is easy to maintain as long as ADIOS2 doesn't break its API. As for unit tests, they should be under testing, there is nothing run/verified under examples so it got pretty outdated over time. Bonus: ADIOS2-Examples has CI on Azure. |
@williamfgc : Ok, cool. I'll open a PR in the examples project. |
This should help with #2000.
A couple things: