We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The function adios2_inquire_group_variables returns an uninitialized pointer (via its variables argument) when the group is empty.
adios2_inquire_group_variables
variables
These lines in its implementation cause the problem:
*size = names.size(); if (*size == 0) return adios2_error_none;
When names is empty, the function returns adios2_error_none, but *variables has not been assigned a value.
names
adios2_error_none
*variables
I think that the code should *variables = nullptr in this case.
*variables = nullptr
Alternatively, the if statement could be removed. The code below should handle the empty case correctly.
if
The text was updated successfully, but these errors were encountered:
adios2_inquire_group_variables: Don't return early
a0f1a77
Closes ornladios#2727.
Successfully merging a pull request may close this issue.
The function
adios2_inquire_group_variables
returns an uninitialized pointer (via itsvariables
argument) when the group is empty.These lines in its implementation cause the problem:
When
names
is empty, the function returnsadios2_error_none
, but*variables
has not been assigned a value.I think that the code should
*variables = nullptr
in this case.Alternatively, the
if
statement could be removed. The code below should handle the empty case correctly.The text was updated successfully, but these errors were encountered: