Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adios2_inquire_group_variables returns uninitialized pointer #2727

Closed
eschnett opened this issue May 28, 2021 · 0 comments · Fixed by #2731
Closed

adios2_inquire_group_variables returns uninitialized pointer #2727

eschnett opened this issue May 28, 2021 · 0 comments · Fixed by #2731

Comments

@eschnett
Copy link
Contributor

The function adios2_inquire_group_variables returns an uninitialized pointer (via its variables argument) when the group is empty.

These lines in its implementation cause the problem:

        *size = names.size();
        if (*size == 0)
            return adios2_error_none;

When names is empty, the function returns adios2_error_none, but *variables has not been assigned a value.

I think that the code should *variables = nullptr in this case.

Alternatively, the if statement could be removed. The code below should handle the empty case correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant