Kill unused variants of DoGetAbsoluteSteps

ornladios · Feb 2, 2022 · fafef48 · fafef48
1 parent ebe21e4
commit fafef48
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/source/adios2/core/Engine.cpp b/source/adios2/core/Engine.cpp
@@ -172,12 +172,6 @@ ADIOS2_FOREACH_STDTYPE_1ARG(declare_type)
     {                                                                          \
         ThrowUp("DoBlocksInfo");                                               \
         return std::vector<typename Variable<T>::BPInfo>();                    \
-    }                                                                          \
-    std::vector<size_t> Engine::DoGetAbsoluteSteps(                            \
-        const Variable<T> &variable) const                                     \
-    {                                                                          \
-        ThrowUp("DoGetAbsoluteSteps");                                         \
-        return std::vector<size_t>();                                          \
     }
 
 ADIOS2_FOREACH_STDTYPE_1ARG(declare_type)

diff --git a/source/adios2/core/Engine.h b/source/adios2/core/Engine.h
@@ -546,9 +546,7 @@ class Engine
     DoAllRelativeStepsBlocksInfo(const Variable<T> &variable) const;           \
                                                                                \
     virtual std::vector<typename Variable<T>::BPInfo> DoBlocksInfo(            \
-        const Variable<T> &variable, const size_t step) const;                 \
-    virtual std::vector<size_t> DoGetAbsoluteSteps(                            \
-        const Variable<T> &variable) const;
+        const Variable<T> &variable, const size_t step) const;
 
     ADIOS2_FOREACH_STDTYPE_1ARG(declare_type)
 #undef declare_type

diff --git a/source/adios2/engine/bp5/BP5Reader.h b/source/adios2/engine/bp5/BP5Reader.h
@@ -166,9 +166,6 @@ class BP5Reader : public BP5Engine, public Engine
      */
     void NotifyEngineNoVarsQuery();
 
-    void DoGetAbsoluteSteps(const VariableBase &variable,
-                            std::vector<size_t> &keys) const;
-
 #define declare_type(T)                                                        \
     void DoGetSync(Variable<T> &, T *) final;                                  \
     void DoGetDeferred(Variable<T> &, T *) final;
@@ -195,6 +192,9 @@ class BP5Reader : public BP5Engine, public Engine
 
     size_t DoSteps() const final;
 
+    void DoGetAbsoluteSteps(const VariableBase &variable,
+                            std::vector<size_t> &keys) const final;
+
     uint32_t m_WriterColumnMajor = 0;
     bool m_ReaderIsRowMajor = true;
     bool m_WriterIsRowMajor = true;