Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust readonly field generation logic #26

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Adjust readonly field generation logic #26

merged 2 commits into from
Jun 18, 2024

Conversation

wanglin86769
Copy link

  1. Use nullable Boolean class instead of primitive boolean for last_readonly and readonly, so that the first value does not equal to null and "readonly" field can show up in WebSocket response.
  2. Ensure both last_readonly and readonly are the OR logic of isReadonly() and !PV_WRITE_SUPPORT, because they will be compared in toJson() method.

@kasemir kasemir merged commit 5f38341 into ornl-epics:main Jun 18, 2024
1 check passed
@kasemir
Copy link
Collaborator

kasemir commented Jun 18, 2024

Looks good.

Are you actually enabling write access in your setup?
How do you control who is allowed to write?

@wanglin86769
Copy link
Author

No, we are not enabling write access.
Our use case at CSNS is using pvws to access PVs at office network via a CA gateway which provides readonly permission and publishes PVs from the control network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants