Support color-printing strings with zero bytes

This is a clean up after fmtlib#1351.
orivej · Oct 10, 2019 · 3240a66 · 3240a66
1 parent a82c1dc
commit 3240a66
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/fmt/color.h b/include/fmt/color.h
@@ -526,8 +526,7 @@ void vprint(std::FILE* f, const text_style& ts, const S& format,
   if (has_style) {
     internal::reset_color<Char>(buf);
   }
-  buf.push_back(Char(0));
-  internal::fputs(buf.data(), f);
+  std::fwrite(buf.data(), 1, buf.size(), f);
 }
 
 /**

diff --git a/test/color-test.cc b/test/color-test.cc
@@ -45,6 +45,8 @@ TEST(ColorsTest, ColorsPrint) {
   EXPECT_WRITE(stdout,
                fmt::print(bg(fmt::terminal_color::bright_magenta), "tbmagenta"),
                "\x1b[105mtbmagenta\x1b[0m");
+  EXPECT_WRITE(stdout, fmt::print(fmt::emphasis::bold, "{}", std::string("a\0b", 3)),
+               std::string("\x1b[1ma\0b\x1b[0m", 11));
 }
 
 TEST(ColorsTest, Format) {