You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When switching from PrimeReact v9.6.3 to v10.8.2, i had to do some migrations due to the feature introduced by primefaces/primereact#4642.
Also, i noticed the inconsistency among the code in utils.d.ts, i.e. AdditionalProps argument is defined to be optional in some places. Yet, I believe, IconOptions was missed out.
This PR makes the AdditionalProps argument for the type IconOptions optional, so that you don't get the following TypeScript error:
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
When switching from PrimeReact v9.6.3 to v10.8.2, i had to do some migrations due to the feature introduced by primefaces/primereact#4642.
Also, i noticed the inconsistency among the code in utils.d.ts, i.e. AdditionalProps argument is defined to be optional in some places. Yet, I believe, IconOptions was missed out.
This PR makes the AdditionalProps argument for the type IconOptions optional, so that you don't get the following TypeScript error:
Beta Was this translation helpful? Give feedback.
All reactions