20250123 Weekly Development Meeting

[josecelano]

• Time: 9:30 in Canary Islands (WET (UTC+0)).
• Time: 10:30 in Vaduz (CET (UTC+1)).

Location:

https://meeting.blockfinance-eco.li/nautiluscyberneeringweeklydevmeeting

Expected duration: 2 to 4 hours with breaks

Communicated attendants:

• Cameron Garnham(@da2ce7) - x
• Jose Celano(@josecelano) - x
• Constantin Bosse(@cgbosse) - x
• Mario Melchor(@mario-nt) - x
• Graeme Byrne(@grmbyrn) - x

---

Agenda:

1. Everyone will take their turn and:

• Go over his notes added as comments for the meeting which will have been added in advance to give an update of all the work done during the previous week indicating.
  • The issues worked on
  • The progress made on them
  • Other things done
• Inform of any faced challenges and request help if necessary to work on specific issues.
• Highlight the encountered difficulties, especially if there is a risk of them causing delays or affecting end product's quality.
• Communicate what will be the next week's tasks.
• List any new topics for further discussion in an additional Technical meeting that he noted for future discussion in comments to this discussion either before the meeting or after his turn so that they get considered.

During the meeting every team member will take their turns and follow this sequence.
The topics for further discussion will be noted in advance by each the team member and to the meetings agenda.

2. At the end of the meeting if there any new technical topics to be discussed further it will be decided to
   set another meeting date for the discussion of these or to hold the meeting hereafter.

Also the persons to be part of the meeting will be decided on so that the others will be free to continue their own work.

[josecelano]

Torrust Tracker

I've continued working on a big refactor of the core tracker type.

Issues:

• Overhaul core Tracker: extract stats torrust/torrust-tracker#1184
• Overhaul core Tracker: extract IoC Container torrust/torrust-tracker#1187
• Overhaul core Tracker: extract whitelist authorization torrust/torrust-tracker#1189
• Overhaul core Tracker: extract authentication torrust/torrust-tracker#1191
• Overhaul core Tracker: refactor authentication module torrust/torrust-tracker#1195
• Overhaul core Tracker: refactor tests (remove duplicate code) torrust/torrust-tracker#1198

As a reminder the goal for this refactor is:

"To make the code simpler, more sustainable and more testable".

I've wanted to change that part since I joined the project. It's a critical part, however we have not improved it that much after adding the tests. At the beginning I added the tests to be able to refactor it safely. That's what I'm doing now.

The refactor will allow:

• Writing unit tests for the core module.
• Sharing the core tracker lib as a new crate.
• Improving compilation times. When you are not working on the core lib you don't need to recompile it.

I think it will take me at least 2 more weeks to finish it because I want to:

• Write unit tests
• Extract the module as a lib crate
• Review docs

See the epic issue for a complete list of sub-issues I'm planning to do.

Just to give you an idea this was the initial Tracker struct when I started the refactor:

pub struct Tracker {
    /// The tracker configuration.
    config: Core,

    /// A database driver implementation: [`Sqlite3`](crate::core::databases::sqlite)
    /// or [`MySQL`](crate::core::databases::mysql)
    database: Arc<Box<dyn Database>>,

    /// Tracker users' keys. Only for private trackers.
    keys: tokio::sync::RwLock<std::collections::HashMap<Key, auth::PeerKey>>,

    /// The list of allowed torrents. Only for listed trackers.
    whitelist: tokio::sync::RwLock<std::collections::HashSet<InfoHash>>,

    /// The in-memory torrents repository.
    torrents: Arc<Torrents>,

    /// Service to send stats events.
    stats_event_sender: Option<Box<dyn statistics::event::sender::Sender>>,

    /// The in-memory stats repo.
    stats_repository: statistics::repository::Repository,
}

And this is the current state:

pub struct Tracker {
    /// The tracker configuration.
    config: Core,

    /// A database driver implementation: [`Sqlite3`](crate::core::databases::sqlite)
    /// or [`MySQL`](crate::core::databases::mysql)
    database: Arc<Box<dyn Database>>,

    /// The service to check is a torrent is whitelisted.
    pub whitelist_authorization: Arc<whitelist::authorization::Authorization>,

    /// The in-memory torrents repository.
    torrents: Arc<Torrents>,
}

NOTE: At the end of the refactor this Tracker type will disappear. It will be replaced by services like:

• AuthenticationService
• KeysHandler
• etc.

Each one with a single responsibility.

I'm not only extracting the services from the tracker but also re-organizing those services internally.

Torrust Website

PR reviews:

• feat(highlight): integrate highlight.js for improved code highlighting torrust/torrust-website#136
• fix browser issues torrust/torrust-website#140

[mario-nt]

Index

• New API endpoint for listing users  torrust/torrust-index#796 (∼)
  • Worked on:
    • Final PR review
    • Add pagination
  • Issues encountered:
  1. It took me a bit of time to understand the code that generate the list of torrents from the database with the given search criteria and to refactor that code so it works with user profiles
  2. After finishing all the code, I noticed a bug, the pagination component was working fine and the GUI was displaying the list of user profiles, but the API endpoint was not returning the correct number of user profiles (Fixed by changing the max default number of results the API returns to 100 - so it is the same as the GUI)
  3. I struggle testing the API endpoint by making calls with the browser or with the cUrl command, when calling the endpoint fromthe GUI it was returning the right number of user profiles but when calling the same endpoing directly to the index I was always getting the default number or results (10 at this moment), Fixed by realizing the query param is written in a different way in the GUI and the Index (page_size vs pageSize)
• Get torrents endpoint max number of results is too small torrust/torrust-index#797
  • Worked on:
    • Fix the bug

API and TYPES lib

• New API endpoint for listing users torrust/torrust-index-api-lib#49 (∼)
  • Worked on:
    • Final review
• Types for new API endpoint for listing users torrust/torrust-index-types-lib#28
  • Worked on:
    • Final review

GUI

• Admins should be able to list users torrust/torrust-index-gui#658

  • Worked on:
    • Adding final styling to the users tab from the admin panel, created a new component using the already made table from the torrents page
    • Added pagination to user list to improve readability
    • Final PR review
  • Issues encountered:
  1. I had to decide what style to apply to the table with the list of users, I used the already made code from the torrents table and tags/categories, and decided to use the table as it looks better for the large amount of info that could be display (users registered in a given index can range from hundreds to even thousands). Also, pagination should work better with the table.
  2. I struggle a bit with getting the desire result for the styles of the table with the list of users. I fixed it by putting the hours playing around with the CSS properties until I was happy with the result, using the pre-existing code in the project.
  3. I had to spent some time understanding how the pagination work with the torrents list to make the component work with the user profiles list
  4. Pagination component was not showing the total number of results (Fixed by calling hte function that load the list of user profiles when the component loads)
  5. Another bug I encountered was that the page number of the url query does not refresh when the pagination size is change, causing the page to not show the correct results or any at all

• Torrent results page is not updated after increased the page size torrust/torrust-index-gui#692

  • Worked on:
    • Fixed the bug

New Issues

• Torrent results page is not updated after increased the page size torrust/torrust-index-gui#692
  • Jose opened this issue regarding a bug I reported while testing pagination in the users tab of the admin panel
• Get torrents endpoint max number of results is too small torrust/torrust-index#797

Next

• Admins should be able to search users torrust/torrust-index-gui#659

[grmbyrn]

Website

Issues:

• Change text in most recent post torrust/torrust-website#138 - changed text when user is on the first blog post to let them know it's the most recent post.
• Improve code highlighter component? torrust/torrust-website#52 - changed code block so that it looked better.
• Navigation issues on certain browsers torrust/torrust-website#137 - removed the reliance on unsupported startViewTransition, ensuring more consistent behaviour across different browsers and preventing navigation issues.
• One resize, PostTable overlaps blog post torrust/torrust-website#139 - ensures that the size value is dynamically updated during window resize events, improving responsiveness and ensuring that the divStyle is always correctly set based on the current window size.

PR:

• fix browser issues torrust/torrust-website#140

Research:

• I worked on an epic to recreate the blog in SvelteKit.
• I researched whether it would be better to use Markdown, SvelteKit or continue with a mixture of the two in the blog.
• I researched whether Playwright could be a good option to prevent issues like Navigation issues on certain browsers torrust/torrust-website#137