Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special chars in filenames #270

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

vinaypuppal
Copy link
Contributor

Hi, thanks for this awesome action. Noticed this error with my coverage files

"Invalid regular expression: /.*filename=\"folder\\/tests\\/__snapshots__\\/test_handlers\\/test_handle[example.com-test0].json\".*line-rate=\"(?<cover>[0-9]+[.]*[0-9]*)\".*/: Range out of order in character class"

The error is because of [example.com-test0] in filename as [ and ] are valid regex syntax.

With this PR filenames with special characters will be correctly handled and escaped with a backslash ()

@orgoro orgoro merged commit c65003f into orgoro:main Sep 29, 2023
@vinaypuppal vinaypuppal deleted the fix-filename-regex-escape branch June 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants