Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate which preferences modal layouts support the serviceCounterLabel #535

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Indicate which preferences modal layouts support the serviceCounterLabel #535

merged 2 commits into from
Jun 24, 2023

Conversation

MoritzLost
Copy link
Contributor

Improves documentation related to #533.

@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cookieconsent-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 9:16am

@netlify
Copy link

netlify bot commented Jun 22, 2023 •
edited
Loading

✅ Deploy Preview for cookieconsentv3-playground canceled.

Name Link
🔨 Latest commit 9f15bde
🔍 Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/649562c82747ab0008b3738b

@MoritzLost MoritzLost mentioned this pull request Jun 22, 2023
Closed
orestbida
orestbida requested changes Jun 22, 2023
View reviewed changes
Copy link
Owner

@orestbida orestbida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to state that the label is hidden when the bar layout is selected or when the viewport is narrow.

@MoritzLost
Copy link
Contributor Author

@orestbida Fair enough, I've changed the wording!

@MoritzLost MoritzLost requested a review from orestbida June 23, 2023 09:16
@orestbida orestbida merged commit 36768e2 into orestbida:v3.0-beta Jun 24, 2023
@orestbida
Copy link
Owner

Thanks for your contribution!

@MoritzLost MoritzLost deleted the improve-service-counter-label-docs branch June 27, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestbida orestbida orestbida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoritzLost @orestbida