Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: data-cc="c-settings": detach from button element #502

Closed
alexanderloewe opened this issue Apr 17, 2023 · 4 comments
Closed

[Feat]: data-cc="c-settings": detach from button element #502

alexanderloewe opened this issue Apr 17, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@alexanderloewe
Copy link

Description

Depending on the design of the website, you may not want to attach the data-cc="c-settings" to a button, so it would be very handy if c-settings would also fuktiomn on other elements like a button, e.g. on a span tag.

Proposed solution

data-cc="c-settings" detach from button element

Additional details

No response

@alexanderloewe alexanderloewe added the enhancement New feature or request label Apr 17, 2023
@github-actions github-actions bot added the triage yet to be reviewed label Apr 17, 2023
@alexanderloewe alexanderloewe changed the title [Feat]: data-cc="c-settings" no button option [Feat]: data-cc="c-settings": detach from button element Apr 17, 2023
@benseven
Copy link

benseven commented Apr 18, 2023 via email

@orestbida orestbida added this to the v2.9.0 milestone Apr 20, 2023
@orestbida orestbida removed the triage yet to be reviewed label Apr 20, 2023
@orestbida
Copy link
Owner

I agree with @benseven, but still will leave this up to the user.

@alexanderloewe
Copy link
Author

Semantics is one thing, I agree with you.

But the practical world is another thing. In my opinion, it would make sens to leave it to the user on which tag he/she would like to use as a trigger for the popup.

@benseven
Copy link

benseven commented Apr 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants