-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: data-cc="c-settings": detach from button element #502
Labels
enhancement
New feature or request
Milestone
Comments
alexanderloewe
changed the title
[Feat]: data-cc="c-settings" no button option
[Feat]: data-cc="c-settings": detach from button element
Apr 17, 2023
The most semantically and accesibly correct element to use for a button is
a <button>, so I’d question why you want to use a <span> or anything else
to do a Button’s job?
On Mon, 17 Apr 2023 at 21:54, Alexander Löwe ***@***.***> wrote:
Description
Depending on the design of the website, you may not want to attach the
data-cc="c-settings" to a button, so it would be very handy if c-settings
would also fuktiomn on other elements like a button, e.g. on a span tag.
Proposed solution
data-cc="c-settings" detach from button element
Additional details
*No response*
—
Reply to this email directly, view it on GitHub
<#502>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANAZC3LUMNTGNSUNQE3R63XBWUWXANCNFSM6AAAAAAXBW5RKE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
ben seven is a designer and web developer, the co-founder of
http://kin.works and founder of https://devicelab.org
*he frequently has to say 'no, sorry' to work or favours to focus on family
and existing projects, and is grateful for your understanding.*
+44 7746 200412 | ***@***.***
|
I agree with @benseven, but still will leave this up to the user. |
Semantics is one thing, I agree with you. But the practical world is another thing. In my opinion, it would make sens to leave it to the user on which tag he/she would like to use as a trigger for the popup. |
Do users browsing with assistive technology - for example a screen reader -
not live in ’the practical world’?
Indeed, such a user can make no practical use of a cookie consent mechanism
unless it’s semantically marked up. This isn’t just a question of
preference, it’s a question of actively excluding users by making poor
engineering decisions. What’s the real-world circumstance in which you
can’t use the same styling as you would on the <span> for the correct
functional HTML element?
On 20 April 2023 at 15:17:21, Alexander Löwe ***@***.***) wrote:
Semantics is one thing, I agree with you.
But the practical world is another thing. In my opinion, it would make sens
to leave it to the user on which tag he/she would like to use as a trigger
for the popup.
—
Reply to this email directly, view it on GitHub
<#502 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANAZC7EQYDAN6PRBGIJ7O3XCFAPDANCNFSM6AAAAAAXBW5RKE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Depending on the design of the website, you may not want to attach the data-cc="c-settings" to a button, so it would be very handy if c-settings would also fuktiomn on other elements like a button, e.g. on a span tag.
Proposed solution
data-cc="c-settings" detach from button element
Additional details
No response
The text was updated successfully, but these errors were encountered: