[Feat]: Allow customisation of script type on accept (mainly for use with Partytown)

[spacedawwwg]

cookieconsent/src/cookieconsent.js

Line 1624 in 540c235

curr_script.type = 'text/javascript';

It would be nice to be able to change the type to type="text/partytown" and trigger a ptupdate after consent is given

https://partytown.builder.io/partytown-scripts#dynamically-appending-scripts

Idea 💡

on a script you add data-type="text/partytown"

change line 1624 to:

// 99% of the time people will want the default
curr_script.type = curr_script.getAttribute('data-type') || 'text/javascript';

then a user can handle their own callback

//...
cc.run({
    // ...
    onAccept: function(cookie){
        window.dispatchEvent(new CustomEvent('ptupdate'));
    },
    // ...
});

What do you think?

[orestbida]

Hi @spacedawwwg,

this feature is already implemented in v3. However, since this is a very tiny code addition, we can also implement it in v2.

[spacedawwwg]

Boom 💥

[preetamslot]

@orestbida
I tested this in 2.9.0 and 3. But it looks like only the first script is activated, other scripts get ignored. Am I doing something wrong?

If you look at the screenshot, first script is now active type="text/partytown-x". the second is still type="text/plain"

Thanks

[orestbida]

@spacedawwwg,

the first script in the screenshot has a src attribute, and the current implementation will wait for the onload/onerror event to fire before loading other script tags, to ensure that all script tags are loaded sequentially.

cookieconsent/src/utils/scripts.js

Lines 164 to 170 in 1efe109

	if(src){
	// load script sequentially => the next script will not be loaded
	// until the current's script onload event triggers
	freshScript.onload = freshScript.onerror = () => {
	loadScriptsHelper(scripts, ++index);
	};
	}

The onload/onerror event — however — is never fired due to the invalid javascript mime type: type="text/partytown-x". This also prevents all the other scripts from loading.

[orestbida]

@spacedawwwg please try this branch and let me know if that fixes it!