Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS problem with RTL #388

Closed
pinkasey opened this issue Oct 9, 2022 · 5 comments
Closed

CSS problem with RTL #388

pinkasey opened this issue Oct 9, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@pinkasey
Copy link

pinkasey commented Oct 9, 2022

This is what the plugin looks like with direction: rtl; in the body:
image

For reference, here it is with direction: ltr;
image

(I'm opening this issue after opening the exact same issue on 68publishers/cookie-consent#42)
(I might open a PR to fix this, but I'm not sure when)

@orestbida
Copy link
Owner

Hi @pinkasey,

v2 is now in maintenance mode and will receive bugfixes or minor tweaks*. If this can be achieved in few lines of css, sure go ahead.

If I were you, I'd switch to v3. I've already planned on adding full support for RTL languages.

*: I might consider features/options with a tiny implementation

@pinkasey
Copy link
Author

Thanks for the reply.
I currently don't need RTL support, so I don't think I'd invest time in this, I came across this bug by chance.
Also,
I'm a user of 68publishers/cookie-consent, which follows v3, I believe.

I'll revisit this if I have a need for RTL.
Thanks again.

@orestbida
Copy link
Owner

I see.

Currently they're based on cookieconsent v2. They might switch to v3 once it's officially released.

@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2022
@orestbida orestbida added the enhancement New feature or request label Nov 11, 2022
@stale stale bot removed the stale label Nov 11, 2022
@orestbida
Copy link
Owner

v3.0.0-rc.9 has full support for RTL. You can also see it in action in the playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants