Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make instruction parsing field agnostic #956

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Make instruction parsing field agnostic #956

merged 7 commits into from
Dec 13, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 13, 2022

We want instruction parsing to be simple and stable, so that it is easy to maintain consensus over the set of valid inscriptions.

This changes the inscription parser to be simpler and more generic:

  • Unknown fields are ignored
  • All fields can be omitted

The only hard errors are:

  • Missing magic number
  • Non-push instruction
  • Duplicated field

@casey casey enabled auto-merge (squash) December 13, 2022 22:30
@casey casey merged commit a0e37c4 into master Dec 13, 2022
@casey casey deleted the generic-inscription-parsing branch December 13, 2022 22:43
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
@casey
Make inscription parser more lenient (ordinals#956)
fb2ae48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph