Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pointer spec #2499

Merged
merged 21 commits into from
Oct 9, 2023
Merged

Implement pointer spec #2499

merged 21 commits into from
Oct 9, 2023

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Oct 5, 2023 •
edited
Loading

TODO:
- [ ] move logic into update_inscription_location()

  • refactor spaghetti if else
  • many more tests
  • handle reinscriptions
  • handle cursedness
  • trailing zeros

@raphjaph raphjaph marked this pull request as ready for review October 8, 2023 11:31
@raphjaph raphjaph requested a review from casey October 8, 2023 11:31
casey
casey approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭

@casey casey force-pushed the implement-pointer-spec branch from 0d2cba6 to 5b88ce1 Compare October 9, 2023 00:18
@raphjaph raphjaph enabled auto-merge (squash) October 9, 2023 18:43
@raphjaph raphjaph merged commit 2df68b7 into master Oct 9, 2023
@raphjaph raphjaph deleted the implement-pointer-spec branch October 9, 2023 18:50
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
@raphjaph
Implement pointer spec (ordinals#2499)
5250110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphjaph @casey