Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused content_response match statement #2384

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Remove unused content_response match statement #2384

merged 3 commits into from
Aug 29, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Aug 28, 2023

The None case of this match statement will never have an effect, since we do body? later one, which will case the whole function to return None if the body is empty.

@casey casey requested a review from raphjaph August 28, 2023 23:09
raphjaph
raphjaph approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, let's try to put it in the right spot

@casey casey enabled auto-merge (squash) August 29, 2023 18:08
@casey casey merged commit 04701d2 into master Aug 29, 2023
@casey casey deleted the remove-cache-control-nop branch August 29, 2023 18:24
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
@casey
Remove unused content_response match statement (ordinals#2384)
2b27ea7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph