Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Reject failed transactions in TransactionProcessor + commitment fix #24

Merged
merged 6 commits into from
Jan 26, 2023
Merged

Reject failed transactions in TransactionProcessor + commitment fix #24

merged 6 commits into from
Jan 26, 2023

Conversation

odcheung
Copy link
Collaborator

#22 was reverted in v0.1.8 due to a bug in the commit.

Testing

  • Verified on local build that whirlpools-sdk tests all pass.
  • Verified on Orca UI that transactions function accordingly

@odcheung odcheung requested a review from rawfalafel January 26, 2023 15:16
rawfalafel
rawfalafel approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@rawfalafel rawfalafel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rawfalafel rawfalafel merged commit 83315db into main Jan 26, 2023
@rawfalafel rawfalafel deleted the meep/tb-fix branch January 26, 2023 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rawfalafel rawfalafel rawfalafel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odcheung @rawfalafel