Trigger_sound_build_cmake branch #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in install bug fix from main to test XRSound install
…install directories. XRsound now works in 32 and 64 bit.
…ib build artifacts generated by the Orbiter CMake project are the correct build type and CPU architecture. Initial version
Fixed table formatting and polished it up.
XRSound-lib-linktest VS 2019 solution and project
Corrected the list of project configurations that need to pass.
… to make it easier to modify.
…iter into trigger_sound_build_cmake Incorporate upstream commit to be able to push next commit.
mschweiger
reviewed
Aug 9, 2021
There was a problem hiding this comment.
All looks good to me. I did push another commit to the branch (before I saw the PR). This just added a user macro to the XRSound-lib-linktest project to make it easier to specify a different Orbiter build directory (which I had to do for my setup). I reverted the macro to the default location, so it should still work for you out of the box. If it is ok and you are happy I'll merge the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch should be ready for merge now, if you agree it's ready.