-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding msbuild+CMake+VS2019 CI build #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start, would be good if we could get some testing integrated into the pipeline
Are x64 builds supposed to fail? |
Yes, the codebase is not currently x64-compatible, but given it's the №1 item in TODO - and there are already a few people working on it - I left it in intentionally |
So maybe run the x64 builds only for commits tagged with |
I'll let @mschweiger decide on that |
Fair. It was just a suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting up the CI build. I have one question: will this try to build both the x86 and x64 versions? My master branch currently doesn't build x64. Could this be set up so that it only builds x86 when pushing to the master branch, but builds x64 when pushing to a different, x64-dedicated branch?
Yes, it could. The action just has to be set up to trigger upon push to the x64-branch. But the branch has to be created first. If you don't want to set-up an entire branch, you could use commit and PR tags instead. |
I've got a promising branch that might compile for both x86 and x64. About to merge into master, so I'll give the CI setup a try. Fingers crossed! |
Adds a basic CI workflow which builds the project in both x86 and x64 platforms.
Example run: https://github.com/DarkWanderer/orbiter/runs/3196658204?check_suite_focus=true